[autobackport: sssd-2-10] KCM: fix TGT renewal use-after-free and stabilize test - #9017
Merged
alexey-tikhonov merged 3 commits intoJul 28, 2026
Conversation
alexey-tikhonov
approved these changes
Jul 28, 2026
added 3 commits
July 28, 2026 19:01
auth_data->ccname pointed at cc->name on a short-lived tmp_ctx that is freed before the tevent immediate renewal callback runs. Copy the name onto auth_data so krb5_child renews the correct KCM ccache. Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 2373a46)
Avoid leaking the partially initialized auth_data when strdup or tevent_create_immediate fails in kcm_creds_check_times(). Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 854dcda)
Use a 10s lifetime and 30s renewable life so renew_till stays past endtime, and poll for half-life plus slack after the UAF fix. Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Cursor Sonnet 5 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 3efe248)
Contributor
Author
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9005-to-sssd-2-10
branch
from
July 28, 2026 19:01
b517bd3 to
ba17b16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9005 KCM: fix TGT renewal use-after-free and stabilize test to branch sssd-2-10, created by @danlavu.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
2373a46 - KCM: fix use-after-free of ccache name during TGT renewal
854dcda - KCM: free auth_data on TGT renewal setup failure
3efe248 - tests: widen KCM TGT renewal poll window
Backported commits
Original Pull Request Body
auth_data->ccnamepointed at a short-livedtmp_ctxccache name freed before the tevent renewal callback (caused flaky renewals against bogus names likeKCM:p).auth_dataon strdup /tevent_create_immediatefailure paths.Replaces the exploratory work in #8857.
Co-authored-by: Cursor cursoragent@cursor.com
Model used: Cursor Sonnet 5