Fix invalid PR workflow permissions and guidance - #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targetso the declared write permissions remain available for pull requests from forksRoot cause
Run
30388087313, job90372357551, received a read-onlyGITHUB_TOKEN(Issues: read,PullRequests: read). The workflow then calledgh pr close --comment, which requires permission to add a comment and update the pull request state, causingResource not accessible by integration (addComment).Verification
The workflow no longer checks out pull request contents and passes event-derived values through environment variables rather than interpolating them directly into shell code.