Mostly fixes #5528 - #5585
Conversation
|
The provider branding requires the provider to have some configured, otherwise it will just return nothing as you have noted. I believe this is working as Dan intended. But we are probably missing some fallback as this PR implies 😅 The PR mostly looks fine to me, although I am not sure I understand the endpoint comment. Is it still supposed to be a draft? |
|
Response from I'm not sure how to use the UCloud "logo" value here. Currently, I think every logo usage uses the fallback values. Until that works for at least one provider, it should probably be a draft. |
|
I have created #5614 |
|
#5614 has been fixed |
|
I'll merge into this branch and test it out. |
|
Merged |
Uses fallbacks value for logos that has
/in them. Not sure what endpoint these should be using.Example:
/ucloud/ucloud/provider/branding/image?name=provider_logo_e5cd953530d2c8ad6e4ad4fa86e80929f158bd602087f1add75e4c53d74c2905.pngI'm assuming it should just be rhs of the query parameters, but
/api/branding/image?name=<rhs>doesn't respond with anything.EDIT: Another thing:
The provider string in a drives specification (
drive.specification.product.provider) doesn't seem to have a match stored in the backend in some cases. What the frontend queries is["ucloud", "hippo", "aau", "aau-k8", "sdu-odense"], but the provider branding only has entries (but not necessarily filled) for["aau-k8", "sdu-odense", "ucloud"](Related #5559)