Skip to content

Mostly fixes #5528 - #5585

Draft
Tiggles wants to merge 10 commits into
masterfrom
issue-5528
Draft

Mostly fixes #5528#5585
Tiggles wants to merge 10 commits into
masterfrom
issue-5528

Conversation

@Tiggles

@Tiggles Tiggles commented May 21, 2026

Copy link
Copy Markdown
Contributor

Uses fallbacks value for logos that has / in them. Not sure what endpoint these should be using.
Example: /ucloud/ucloud/provider/branding/image?name=provider_logo_e5cd953530d2c8ad6e4ad4fa86e80929f158bd602087f1add75e4c53d74c2905.png

I'm assuming it should just be rhs of the query parameters, but /api/branding/image?name=<rhs> doesn't respond with anything.

EDIT: Another thing:

The provider string in a drives specification (drive.specification.product.provider) doesn't seem to have a match stored in the backend in some cases. What the frontend queries is ["ucloud", "hippo", "aau", "aau-k8", "sdu-odense"], but the provider branding only has entries (but not necessarily filled) for ["aau-k8", "sdu-odense", "ucloud"] (Related #5559)

@DanThrane

Copy link
Copy Markdown
Collaborator

The provider branding requires the provider to have some configured, otherwise it will just return nothing as you have noted. I believe this is working as Dan intended. But we are probably missing some fallback as this PR implies 😅

The PR mostly looks fine to me, although I am not sure I understand the endpoint comment. Is it still supposed to be a draft?

@Tiggles

Tiggles commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Response from GET https://cloud.sdu.dk/api/providers/branding/browse on production. I'm omitting some keys in the Map/Record-object that's returned:

{
         /* Omitted keys/values */
	"ucloud": {
		"logo": "/ucloud/ucloud/provider/branding/image?name=provider_logo_ef76688b76aa493bf26cce96a51fd51d8af1780c7a41e4b525f900da86b5ca09.png",
                  /* Omitted keys/values */
	}
}

I'm not sure how to use the UCloud "logo" value here.

Currently, I think every logo usage uses the fallback values. Until that works for at least one provider, it should probably be a draft.

@DanThrane

Copy link
Copy Markdown
Collaborator

I have created #5614

@DanThrane

Copy link
Copy Markdown
Collaborator

#5614 has been fixed

@Tiggles

Tiggles commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

I'll merge into this branch and test it out.

@Tiggles

Tiggles commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Merged master into this branch, but I can't really test it with my current local backend as the Provider K8s logo url is empty. These changes aren't live on dev, so I can't see the difference there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants