Add public close() to release the HTTP client - #29
Open
townsmcp wants to merge 2 commits into
Open
Conversation
Added a close method to release HTTP client connections.
Added a close method to the API client for resource management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
SaicApiClientowns anhttpx.AsyncClientthat previously had no publicmeans of being closed, so consumers couldn't release the transport after
use or after a failed login — it leaked until GC/process exit. This adds:
SaicApiClient.close()— callsaclose()on the underlyinghttpx.AsyncClient.AbstractSaicApi.close()— delegates to the client'sclose().The change is additive and backward-compatible; no existing behaviour is
altered. Verified that after
await api.close()the underlying client'sis_closedisTrue.Downstream context: the mg-saic-ha Home Assistant integration currently
reaches the private httpx client to close it as a workaround; once this
ships, it can use the public method instead.