Feat: clearer naming convention for init-level dicts GRIPPER_OFFSETS#322
Open
tenfoldpaper wants to merge 3 commits into
Open
Feat: clearer naming convention for init-level dicts GRIPPER_OFFSETS#322tenfoldpaper wants to merge 3 commits into
tenfoldpaper wants to merge 3 commits into
Conversation
juelg
reviewed
Jul 20, 2026
|
|
||
| GRIPPER_MOUNT_OFFSETS: dict[common.GripperType, common.Pose] = { | ||
| common.GripperType.FrankaHand: common.Pose(rotation=common.FrankaHandTCPOffset()[:3, :3], translation=np.array([0.0, 0.0, 0.0])), | ||
| common.GripperType("Robotiq2F85"): common.Pose(translation=np.array([0.0, 0.0, 0.0]), quaternion=np.array([0.0, 0.0, 0.7071068, 0.7071068])), |
Contributor
There was a problem hiding this comment.
shouldnt the mounting offset for the 2f85 have no rotation at all?
Collaborator
Author
There was a problem hiding this comment.
Nope, we had this discussion during our previous project, it requires a 90 degree offset. I double-checked it with the photographs of 2f85-mounted FR3.
Collaborator
Author
There was a problem hiding this comment.
This line here shows the mounting transform that was actually used for the FR3Duo setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the package root
__init__.pycontains the variableGRIPPER_OFFSETS, which actually indicates the TCP offset for different grippers. Propose renaming it toGRIPPER_TCP_OFFSETSand introduce a new variableGRIPPER_MOUNT_OFFSETSto clearly differentiate between the two.FR3DUO setup is not affected, because it was using a member variable instead of using something defined in
__init__.Went through existing files and updated existing
GRIPPER_OFFSETSto the newGRIPPER_TCP_OFFSETS.Unclear:
Existing TCP offset value for Robotiq2F85 only defines translation, not rotation (left as identity):
common.GripperType("Robotiq2F85"): common.Pose(translation=np.array([0, 0.0, 0.1493])),Comparing Franka Hand TCP offset and mounting offset values, it seems that the TCP offset's rotation follows the mounting offset's:
TCP: common.GripperType.FrankaHand: common.Pose(pose_matrix=common.FrankaHandTCPOffset())Mounting: common.GripperType.FrankaHand: common.Pose(rotation=common.FrankaHandTCPOffset()[:3, :3], translation=np.array([0.0, 0.0, 0.0])),which means that Robotiq2F85's TCP offset needs to be updated (pseudocode) as:
common.GripperType("Robotiq2F85"): common.Pose(rotation=robotiq2f85_mount_rotation, translation=np.array([0, 0.0, 0.1493])),