Fix image handle.ptr and empty region - #141
Merged
Merged
Conversation
RobLoach
commented
Jul 28, 2026
RobLoach
commented
Jul 28, 2026
Co-authored-by: Rob Loach <robloach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes NK_COMMAND_IMAGE fall back to the full texture size when the image region is empty, and lets NuklearImageToTexture resolve nk_image_ptr handles as Texture pointers, so images built with upstream Nuklear constructors render correctly. Adds pixel-level test coverage. Fixes #130