docs(ui): refresh GetRoster field-name commentary for the handle flip (RIG-2882) - #723
Merged
Merged
Conversation
… (RIG-2882) RIG-2880 (#698) flipped the request-side comms fields from account-ids to `@handle` inputs, renaming `GetRosterRequest.agent_account_id` -> `vantage_handle`. The `fetchSnapshot` comment still named the old `agent_account_id` field twice while describing the current wire contract; retarget it at `vantage_handle`. Code was already correct (the call site sends only `{ scope }`, leaving the handle field empty). This is the T7 stale-commentary item from the frozen handle-addressing cutover record. Sweep-confirm + suite-run (1029/0 against the regenerated client) recorded on RIG-2882. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-ui-rig-2882-t7-handl.compass-eng-docs.pages.dev Deployed from |
mattwilkinsonn
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RIG-2880 (#698) flipped the request-side comms fields from account-ids to
@handleinputs, renamingGetRosterRequest.agent_account_id->vantage_handle.The
fetchSnapshotcomment still named the oldagent_account_idfield twicewhile describing the current wire contract; retarget it at
vantage_handle.Code was already correct (the call site sends only
{ scope }, leaving thehandle field empty). This is the T7 stale-commentary item from the frozen
handle-addressing cutover record. Sweep-confirm + suite-run (1029/0 against the
regenerated client) recorded on RIG-2882.
Co-authored-by: Matt Wilkinson matt@rigel.build