Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatic assignment rules could appear deleted in the UI but reappear after navigating away and back.
The reason was that the frontend query-builder includes a transient
inTheLastproperty in the deletion payload, while existing MongoDB rules may not contain it. Because MongoDB$pullrequires an exact embedded-document match, the rule was not actually removed.The backend now normalizes automatic-assignment rules before comparison, locates the matching stored rule, and removes that exact stored document. New rules are also normalized before persistence to prevent transient UI state from being stored. Also, automatically assigned users are derived from active rules, so once the rule is removed, users matching only that rule are no longer automatically assigned.
Useful links
Type of change
How Has This Been Tested?
inTheLast, sends a deletion request containing the transient property, and verifies the rule is removed.Commands run:
npx eslint src/schema/mutation/editRole.mutation.ts
npx eslint --no-ignore tests/unit-tests/schema/mutation/editRole.mutation.spec.ts
npm test -- --runInBand tests/unit-tests/schema/mutation/editRole.mutation.spec.ts
npm run build
Manual verification:
Screenshots
Not applicable. This is a backend-only fix with no visual changes.
Checklist:
( * == Mandatory )