Integration with Argus.jl - #83
Merged
Merged
Conversation
Collaborator
Author
Collaborator
|
I just pushed into your branch. |
Collaborator
|
another push. I suspect that the getting coverage does not work, maybe because of the extensive macro expansions. The following code successfuly executes the tests: import Pkg; Pkg.test(;julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], allow_reresolve=true, coverage=false, force_latest_compatible_version=false)However, the one actually used by the workflow (before my last commit) was doing: import Pkg; Pkg.test(;julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], allow_reresolve=true, coverage=true, force_latest_compatible_version=false)Which breaks. |
Collaborator
|
Also, I had to exclude x84, again, no idea why. |
Collaborator
Author
|
Let's wait for the latest Argus release to be merged. I'll add back coverage and x84 tests afterwards. I think they will pass this time. |
Collaborator
Author
|
@bergel All good now :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major change that removes the
CSTParser.jldependency in favour ofArgus.jl.The new approach uses Argus for writing and matching rules in a more expressive way than before. It is now possible to:
RuleGroups;Apart from new features and improvements, this PR also brings a major reorganisation and cleaning up. Still, there is still some work that can be done for even further improvement (e.g. more instructive logs, remove/replace some unnecessary functions such as
run_lint_on_text).I believe this PR is good to merge as-is.