Skip to content

docs: remove the JustDummies records this repository no longer owns - #412

Merged
Reefact merged 1 commit into
mainfrom
claude/french-responses-fbdmo6
Aug 7, 2026
Merged

docs: remove the JustDummies records this repository no longer owns#412
Reefact merged 1 commit into
mainfrom
claude/french-responses-fbdmo6

Conversation

@Reefact

@Reefact Reefact commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

The documentation half of ADR-0069, after the code left in #411. 149 files. The tag archive/justdummies-adr marks the last commit carrying these records.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Analyzer / diagnostic change
  • Tests
  • Documentation
  • Build / CI / tooling

What was removed, and how the set was chosen

  • 33 ADRs (66 files with translations), 28 JD analyzer pages (56 files), the dated JustDummies architecture audit (2 files).

The criterion is the moved / adopted column of the renumbering table in just-dummies ADR-0045not a text search. moved means the decision left with its code; adopted means it is live in both repositories. Nine adopted ADRs stay.

That distinction is load-bearing: ADR-0048 "Guarantee a generated regex value matches its pattern" does not contain the word "dummies" anywhere and is entirely about JustDummies, while several mutation-gate ADRs mention it constantly and are FirstClassErrors decisions. A grep would have kept the first and dropped the others.

Four ADRs are kept although they concern JustDummies, as ADR-0069 requires: ADR-0006, ADR-0011, ADR-0026, ADR-0061. They record decisions this repository made, and FirstClassErrors.Testing's current shape is unreadable without them.

Links, not just files

Every markdown link from a surviving page to a removed ADR now points at its renumbered file in Reefact/just-dummies — 16 files repointed. Replacing a record with a dead link would be worse than either.

Verified with a link checker over every relative .md link in the repository: 1 dead link left, and it predates this changeADR-0024's French page links to adr/README.fr.md, which has never existed in any commit. Left alone deliberately: editing an accepted ADR in place is not mine to do.

The index reconciles exactly: 35 rows, 35 files, no orphan in either direction. That check also caught a duplicated row in the original index (69 rows for 68 ADRs).

One place deliberately untouched

The dated 2026-07-20 FirstClassErrors audit mentions removed ADRs in prose, with no links to them. Rewriting a dated finding would falsify it, so its text stands. Only its single link to the JustDummies audit is repointed at the other repository.

A section the checklist did not have

AddingAReleaseTrain.{en,fr}.md gains "Removing a train", because #411 taught something the runbook did not know: a workflow that publishes a required status check leaves that requirement behind when deleted, and every later pull request then sits at mergeable_state: blocked with every check green — a state that reads as a content problem and is not one. It cost this migration one debugging round. The section also states plainly that dropping a requirement for code the repository no longer contains is not a weakened protection.

Testing

  • dotnet build FirstClassErrors.sln — 0 warnings, 0 errors
  • dotnet test FirstClassErrors.sln — 0 failures
  • Relative-markdown-link check across the repository (result above)
  • ADR index ↔ ADR files reconciliation, both directions

Documentation

  • README / doc/ updated
  • French translation updated alongside the English page it mirrors — the analyzers index, the mutation page, the changelog page, AddingAReleaseTrain
  • Public API / analyzer documentation updated — the JDxxx pages are gone; the published JustDummies analyzers' HelpLinkUri already points at just-dummies, verified in its HelpLinks.cs, so no live help link breaks.

Architecture decisions

  • No architectural decision in this pull request — it executes Accepted ADR-0069.

Related issues

Refs #404 — this completes the cutover it tracks.


Generated by Claude Code

Repository owner deleted a comment from chatgpt-codex-connector Bot Aug 7, 2026
The documentation half of ADR-0069, after the code left in the previous change.

Removed: the 33 ADRs the renumbering table marks 'moved' (66 files with their
translations), the 28 JD analyzer pages (56 files), and the dated JustDummies
architecture audit. ADR-0069 keeps ADR-0006, ADR-0011, ADR-0026 and ADR-0061:
they record decisions THIS repository made, and FirstClassErrors.Testing's shape
is unreadable without them.

The 'moved' versus 'adopted' column of that table is the criterion, not a text
search. Nine ADRs are adopted — live in both repositories — and stay; ADR-0048
'Guarantee a generated regex value matches its pattern' does not contain the word
'dummies' anywhere and is entirely about JustDummies. A grep would have kept it
and dropped the mutation-gate decisions.

Links, not just files: every markdown link from a surviving page to a removed ADR
now points at its renumbered file in Reefact/just-dummies. Replacing a record with
a dead link is worse than either. The index reconciles exactly — 35 rows, 35 files,
no orphan in either direction.

The dated 2026-07-20 audit is the one place left untouched: it mentions removed
ADRs in prose, carries no link to them, and rewriting a dated finding would
falsify it. Only its one link to the JustDummies audit is repointed.

AddingAReleaseTrain gains a 'Removing a train' section, in both languages,
because removing the dum train taught something the checklist did not know:
a workflow that publishes a REQUIRED status check leaves the requirement behind
when it is deleted, and every later pull request then sits at blocked with every
check green. It cost this migration one debugging round.

Refs: #404
@Reefact
Reefact force-pushed the claude/french-responses-fbdmo6 branch from a2ac826 to c558ce7 Compare August 7, 2026 21:28
@Reefact
Reefact enabled auto-merge (rebase) August 7, 2026 21:29
@Reefact
Reefact merged commit 5d53b76 into main Aug 7, 2026
24 checks passed
@Reefact
Reefact deleted the claude/french-responses-fbdmo6 branch August 7, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants