Skip to content

build(testing): consume JustDummies as a published package #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Reefact merged 1 commit into from
Aug 7, 2026
Merged

build(testing): consume JustDummies as a published package #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<PackageVersion Include="coverlet.collector" Version="10.0.1" />
<PackageVersion Include="FsCheck" Version="3.3.4" />
<PackageVersion Include="JetBrains.Annotations" Version="2026.2.0" />
<PackageVersion Include="JustDummies" Version="1.0.0-preview.1" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="5.6.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.6.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.6.0" />
Expand Down
15 changes: 5 additions & 10 deletions FirstClassErrors.RequestBinder.UnitTests/FirstClassErrors.RequestBinder.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,12 @@
<ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
<ProjectReference Include="..\FirstClassErrors.RequestBinder\FirstClassErrors.RequestBinder.csproj" />
<ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
<!-- Direct reference: Testing references JustDummies privately (PrivateAssets=all), so it does not flow
transitively; this project uses JustDummies.Any.* directly for arbitrary primitives. -->
<ProjectReference Include="..\JustDummies\JustDummies.csproj" />
<!-- Declared here although Testing now flows it transitively: this project uses JustDummies.Any.*
directly, and a direct use gets a direct reference. -->
<PackageReference Include="JustDummies" />

<!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
PrivateAssets=all stops the reference from reaching a consumer of this project. -->
<ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
<!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
</ItemGroup>

<ItemGroup>
Expand Down
11 changes: 3 additions & 8 deletions FirstClassErrors.Testing.UnitTests/FirstClassErrors.Testing.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,10 @@
<ItemGroup>
<ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
<ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
<ProjectReference Include="..\JustDummies\JustDummies.csproj" />
<PackageReference Include="JustDummies" />

<!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
PrivateAssets=all stops the reference from reaching a consumer of this project. -->
<ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
<!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
</ItemGroup>

<ItemGroup>
Expand Down
34 changes: 10 additions & 24 deletions FirstClassErrors.Testing/FirstClassErrors.Testing.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,18 @@

<ItemGroup>
<ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
<!-- JustDummies backs the arbitrary-value factories (ADR-0026). It is not yet on NuGet (ADR-0011), so
reference it privately and embed its assembly in this package (see the pack target below);
switch to a NuGet PackageReference once JustDummies is published. -->
<ProjectReference Include="..\JustDummies\JustDummies.csproj" PrivateAssets="all" />

<!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
PrivateAssets=all stops the reference from reaching a consumer of this project. -->
<ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
<!-- JustDummies backs the arbitrary-value factories (ADR-0026), and is now a published package.
Declared WITHOUT PrivateAssets, unlike every other reference here: a consumer restoring this
package must get JustDummies too, since the factories call into it at runtime. That makes it a
real, visible dependency where it used to be an assembly smuggled into lib/ — and it is a
PRERELEASE dependency, deliberately and temporarily, so the split can happen before JustDummies
reaches 1.0 stable. This package cannot ship a stable version until that one does. -->
<PackageReference Include="JustDummies" />

<!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
under analyzers/dotnet/cs, so the PackageReference above loads them at build and in the IDE. -->
</ItemGroup>

<!-- While JustDummies is unpublished, carry JustDummies.dll inside this package's lib/ so a consumer restores it
transparently. PrivateAssets=all above emits no JustDummies <dependency>, so the embedded copy is the
only one. Remove this whole block when JustDummies moves to a NuGet PackageReference (ADR-0026 follow-up). -->
<PropertyGroup>
<TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);IncludeJustDummiesInPackage</TargetsForTfmSpecificBuildOutput>
</PropertyGroup>
<Target Name="IncludeJustDummiesInPackage">
<ItemGroup>
<BuildOutputInPackage Include="$(OutputPath)JustDummies.dll" />
</ItemGroup>
</Target>

<ItemGroup>
<!-- Embed an SPDX SBOM (software bill of materials) inside the package at pack time
(_manifest/spdx_2.2/manifest.spdx.json), so the inventory of files and dependencies travels with
Expand Down
17 changes: 6 additions & 11 deletions FirstClassErrors.UnitTests/FirstClassErrors.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,12 @@
<ItemGroup>
<ProjectReference Include="..\FirstClassErrors\FirstClassErrors.csproj" />
<ProjectReference Include="..\FirstClassErrors.Testing\FirstClassErrors.Testing.csproj" />
<!-- Direct reference: Testing references JustDummies privately (PrivateAssets=all), so it does not flow
transitively; this project uses JustDummies.Any.* directly for arbitrary primitives. -->
<ProjectReference Include="..\JustDummies\JustDummies.csproj" />

<!-- Run the JustDummies analyzers on this project (ADR-0061): OutputItemType=Analyzer loads them at
build and in the IDE, ReferenceOutputAssembly=false keeps them off the runtime graph, and
PrivateAssets=all stops the reference from reaching a consumer of this project. -->
<ProjectReference Include="..\JustDummies.Analyzers\JustDummies.Analyzers.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
<!-- Declared here although Testing now flows it transitively: this project uses JustDummies.Any.*
directly, and a direct use gets a direct reference. -->
<PackageReference Include="JustDummies" />

<!-- The JustDummies analyzers (ADR-0061) need no reference of their own: the package carries them
under analyzers/dotnet/cs, so a PackageReference loads them at build and in the IDE. -->
</ItemGroup>

<ItemGroup>
Expand Down
Loading