Skip to content

Fix Workshop autoexec command buffer overflow #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitsune44 merged 1 commit into from
Aug 8, 2026
Merged

Fix Workshop autoexec command buffer overflow #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/game/shared/swarm/rd_workshop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,12 +1145,22 @@ void CReactiveDropWorkshop::UnloadTemporaryAddons()

void CReactiveDropWorkshop::RerunAutoExecScripts()
{
// Only queue an exec for addons that actually ship an autoexec_<id>.cfg
// file. Queueing one command per subscribed addon floods the engine's small
// console command buffer: with 150+ subscribed addons the pending commands
// alone exceed the buffer size, and later commands (such as "quit") get
// dropped with "Cbuf_AddText: buffer overflow". File existence is checked
// above, so a plain "exec" is enough (no need for execifexists).
FOR_EACH_VEC( m_LoadedAddonPaths, i )
{
if ( IsSubscribedToFile( m_LoadedAddonPaths[i].ID, false ) )
{
engine->ClientCmd_Unrestricted( VarArgs( "execifexists autoexec_%llu\n", m_LoadedAddonPaths[i].ID ) );
}
if ( !IsSubscribedToFile( m_LoadedAddonPaths[i].ID, false ) )
continue;

CFmtStr szAutoExecFile{ "cfg/autoexec_%llu.cfg", m_LoadedAddonPaths[i].ID };
if ( !g_pFullFileSystem->FileExists( szAutoExecFile, "GAME" ) )
continue;

engine->ClientCmd_Unrestricted( VarArgs( "exec autoexec_%llu\n", m_LoadedAddonPaths[i].ID ) );
}
}
#endif
Expand Down Expand Up @@ -2233,7 +2243,13 @@ void CReactiveDropWorkshop::RealLoadAddon( PublishedFileId_t id )
ASWGameRules()->m_iMissionWorkshopID = g_ReactiveDropWorkshop.FindAddonProvidingFile( szOverview );
}
#else
engine->ClientCmd_Unrestricted( VarArgs( "execifexists autoexec_%llu\n", id ) );
// Don't queue an exec command for every addon - see RerunAutoExecScripts
// for why. Only addons that actually contain the file are exec'd.
CFmtStr szAutoExecFile{ "cfg/autoexec_%llu.cfg", id };
if ( g_pFullFileSystem->FileExists( szAutoExecFile, "GAME" ) )
{
engine->ClientCmd_Unrestricted( VarArgs( "exec autoexec_%llu\n", id ) );
}
#endif
}

Expand Down
Loading