fix(scan): exclude quarantine output from rescans#20
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Quarantined copies under ~/Desktop/Quarantine were still walked when scanning a parent folder, letting them group with live originals and potentially move the wrong keeper into Quarantine on apply. Co-authored-by: ringlet_fires5b <ringlet_fires5b@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_scanexcluded the app data directory but not~/Desktop/Quarantine. Scanning a parent folder that includes Desktop could re-walk quarantined copies, group them with live originals, and on apply move the wrong keeper into Quarantine.Changed files
src-tauri/src/commands.rs— add normalizedquarantine_out_dirto scan exclude listsrc-tauri/tests/smoke.rs— regression test for quarantine path exclusionTesting performed
cargo test --workspace(blocked in cloud agent: Cargo 1.83 lacks edition2024 for blake3)quarantine_output_path_is_excluded_from_rescansmoke testSafety notes
Exact-hash-only dedup, Dry-default, and quarantine-never-delete semantics preserved. This only prevents quarantined copies from being scanned as duplicate candidates.