Fix Omnipath issue - #86
Merged
Merged
Conversation
Fix OmniPath loading resilience (port NICHESv1 PR RaredonLab#72 / issue RaredonLab#70) Newer OmnipathR (>= ~3.17, incl. 4.1.0) resolves the `organism` argument through ncbi_taxid(), which downloads and coalesces species tables from Ensembl, OMA, and UniProt. When any of those ancillary services is unreachable (e.g. omabrowser.org returning HTTP 502), the call aborts with "Can't combine `..1` and `..3`" even though the OmniPath interaction server itself is fine. load_LRM_database("omnipath") now delegates to a resilient fetcher that: 1. tries the standard OmnipathR path with its console logging muted, 2. falls back to a direct OmniPath REST query using the known NCBI taxon id, bypassing the failing organism-name lookup, and 3. raises an informative network error only if both paths fail. The fallback is base-R only (utils::download.file / read.delim) and adds no new dependencies. Ported from NICHESv1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OmniPath loading resilience (port NICHESv1 PR #72 / issue #70)
Newer OmnipathR (>= ~3.17, incl. 4.1.0) resolves the
organismargument through ncbi_taxid(), which downloads and coalesces species tables from Ensembl, OMA, and UniProt. When any of those ancillary services is unreachable (e.g. omabrowser.org returning HTTP 502), the call aborts with "Can't combine..1and..3" even though the OmniPath interaction server itself is fine.load_LRM_database("omnipath") now delegates to a resilient fetcher that:
The fallback is base-R only (utils::download.file / read.delim) and adds no new dependencies. Ported from NICHESv1.