my improvements (do not merge) - #17
Draft
Bluscream wants to merge 25 commits into
Draft
Conversation
Bluscream
commented
Oct 14, 2023
| else if (!string.IsNullOrWhiteSpace(steam.Summary.PersonaName)) return steam.Summary.PersonaName; | ||
| } | ||
| } | ||
| return string.IsNullOrWhiteSpace(player.Name) ? player.SteamID.ToString() : player.Name; |
Contributor
Author
There was a problem hiding this comment.
this might make sense to replace, so whitespace names are not just whitespace
more loadingscreentext improvements
add public readonly Cache add GetPlayerStats(ulong steamid) add GetPlayerStats(RunnerPlayer player) add private RemovePlayerStats(ulong steamID) add OnStatsRecieved event add BasicProgressionConfiguration.RemoveEntriesFromCacheDelay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not just blindly merge this. if you find anything you want to use, just copy it over (especially the updated default configs pls)
Also ignore the markdown files, they're mostly for my reference and outdated