fix(html-report): handle the missing link in the html ENV table. - #301
Merged
Conversation
Handles the following 2 cases: 1. Config hyperlink — _update_environment_config_links previously decided which Environment row to link by checking whether the filename contained the substring "cluster"/"config". If there is no substring "cluster| config" the it will not show the link. 2. The argument parsing only handled the space-separated form (--cluster_file value), but not the equals form (--cluster_file=value), so the scan never matched and defaulted to "Not specified". Added a shared helper cli_option_value(name, argv=None) in cvs/lib/report_plugins.py that handles both --opt value and --opt=value, and used it in the two places that parsed sys.argv. Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
solaiys
requested review from
amd-droy,
anujmittal-amd,
atnair-amd and
cijohnson
August 10, 2026 20:10
Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
amd-droy
reviewed
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles the following 2 cases:
Config hyperlink — _update_environment_config_links previously decided which Environment row to link by checking whether the filename contained the substring "cluster"/"config". If there is no substring "cluster| config" the it will not show the link.
The argument parsing only handled the space-separated form (--cluster_file value), but not the equals form (--cluster_file=value), so the scan never matched and defaulted to "Not specified".
Added a shared helper cli_option_value(name, argv=None) in cvs/lib/report_plugins.py that
handles both --opt value and --opt=value, and used it in the two places that parsed sys.argv.
Both cases handled correctly (verified functionally):