Skip to content

fix(html-report): handle the missing link in the html ENV table. - #301

Merged
solaiys merged 2 commits into
mainfrom
solaiys/html-env-table-link-fix
Aug 12, 2026
Merged

fix(html-report): handle the missing link in the html ENV table.#301
solaiys merged 2 commits into
mainfrom
solaiys/html-env-table-link-fix

Conversation

@solaiys

@solaiys solaiys commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Handles the following 2 cases:

  1. Config hyperlink — _update_environment_config_links previously decided which Environment row to link by checking whether the filename contained the substring "cluster"/"config". If there is no substring "cluster| config" the it will not show the link.

  2. The argument parsing only handled the space-separated form (--cluster_file value), but not the equals form (--cluster_file=value), so the scan never matched and defaulted to "Not specified".

Added a shared helper cli_option_value(name, argv=None) in cvs/lib/report_plugins.py that
handles both --opt value and --opt=value, and used it in the two places that parsed sys.argv.

Both cases handled correctly (verified functionally):

  • cli_option_value("--config_file", ...) returns the value for both --config_file=./a/b.json (equals) and --config_file ./c.json (space) forms.
  • Environment table linking is now keyed by the recorded kind (cluster/config), not a filename substring — so a config whose name has no "config" token (e.g. mi325x_..._distributed.json) still gets a hyperlink. Confirmed: both Config File and Cluster File render <a href=...> cells .
  • The config_/cluster_ bundle prefixes are retained (bundle hygiene), and _config_files now stores {"rel", "kind"} — all readers/writers (copy_config_files_to_bundle, _update_environment_config_links, the truthiness check) are consistent; no other consumer expects the old string form.

Handles the following 2 cases:
1. Config hyperlink — _update_environment_config_links previously decided
   which Environment row to link by checking whether the filename contained
   the substring "cluster"/"config". If there is no substring "cluster| config"
   the it will not show the link.

2. The argument parsing only handled the space-separated form (--cluster_file value),
   but not the equals form (--cluster_file=value), so the scan never matched and defaulted to "Not specified".

  Added a shared helper cli_option_value(name, argv=None) in cvs/lib/report_plugins.py that
  handles both --opt value and --opt=value, and used it in the two places that parsed sys.argv.

Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
Comment thread cvs/lib/report_plugins.py

@amd-droy amd-droy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@solaiys
solaiys merged commit d4b0223 into main Aug 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants