Fix misleading 'unreachable' log message - #286
Open
cijohnson wants to merge 1 commit into
Open
Conversation
in pssh.prune_nodes() The prune_nodes() method was logging all host removals as 'unreachable' even when hosts were pruned for other reasons (e.g., GID consistency failures, interface validation failures). This was misleading since these hosts were actually reachable over SSH but failed other checks. Changes: - Add optional 'reason' parameter to prune_nodes() (defaults to 'Unreachable') - Add optional 'log_pruning' parameter to avoid duplicate logging - Update preflight checks to pass specific failure reasons - Change preflight summary log level from INFO to WARNING - Apply fixes to both single-process and multiprocess Pssh classes Addresses AIMVT-275: Generic prune_nodes() API should not assume unreachability. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Ignatious Johnson <ichristo@amd.com>
cijohnson
force-pushed
the
ichristo/improve_prune_nodes_logging
branch
from
August 3, 2026 23:03
357e57f to
01d3f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in pssh.prune_nodes()
The prune_nodes() method was logging all host removals as 'unreachable' even when hosts were pruned for other reasons
(e.g., GID consistency failures, interface validation failures). This was misleading since these hosts were actually reachable over SSH but failed other checks.
Changes:
Addresses AIMVT-275: Generic prune_nodes() API should not assume unreachability.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist