[test] Add gfx1250/gfx1251 support and strip xnack target features - #2390
Merged
Conversation
gfx1250 and gfx1251 always operate with xnack enabled and the compiler rejects explicit :xnack+/:xnack- target features. Add these GPUs to the supported list and remove any requested xnack feature from AOMP_TARGET_FEATURES in both Makefile.defs and Makefile.rules so tests that hard-code features still build and run.
saiislam
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
August 3, 2026 18:23
ronlieb
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gfx1250 and gfx1251 always operate with xnack enabled and the compiler rejects explicit :xnack+/:xnack- target features. Add these GPUs to the supported list and remove any requested xnack feature from AOMP_TARGET_FEATURES in both Makefile.defs and Makefile.rules so tests that hard-code features still build and run.
Technical Details
Sustitute AOMP_TARGET_FEATURES with empty string if AOMP_GPU is gfx1250/gfx1251.
Submission Checklist