[Buildbot] Add script for setting up environment for debug/reproduction - #2278
[Buildbot] Add script for setting up environment for debug/reproduction#2278Kewen12 wants to merge 3 commits into
Conversation
jplehr
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
I think it would be great if a user could point to a local LLVM tree and then have that mounted into the container as a volume mount. This reduces the need for re-cloning.
The other question that I had: Do these docker commands that the script uses require a certain docker version to be available?
Good idea! I added a new flag
The docker cmds and options are fundamental which should be available for the versions widely used. So I think we don't have to enforce the version here. |
| name = container_name(args, args.target) | ||
|
|
||
| log(f"Removing container {name}") | ||
| run_cmd(["docker", "rm", "-f", name], check=False) |
There was a problem hiding this comment.
Should we check if the docker exists first?
This fails when the container is still running, right?
|
The revision has the following changes to address comment feedback:
|
This PR provides a script to help developers quickly set up a local environment for debugging or reproducing issues surfaced by our upstream buildbots. Updated readme for detailed instructions.
This script:
Tested locally.