nanocoap: fix byte order of request message ID, and add test application - #7162
Merged
Conversation
aabadie
added
Area: network
Member
|
nanocoap is now part of RIOT, @kb2ma please adapt this accordingly. The changes you requested on nanocoap (use |
kb2ma
force-pushed
the
nanocoap/msgid_byte_order
branch
from
January 12, 2018 10:55
ad6387d to
b3d77ef
Compare
kb2ma
force-pushed
the
nanocoap/msgid_byte_order
branch
from
January 12, 2018 11:00
b3d77ef to
7e5d14f
Compare
Member
Author
|
Adapted to nanocoap in RIOT. Created nanocoap unit test suite. Also, it turns out the byteorder function renaming was merged in #6897, so I think we're good there. |
aabadie
added
the
CI: ready for build
smlng
added
CI: ready for build
Member
|
@kaspar030 any comments on this from your side? |
smlng
changed the title
Member
|
ping @kaspar030, this should go into to the release, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nanocoap was inconsistent in its public interface to the message ID for a request. For details, see the issue and the PR for the fix. This PR updates RIOT's package to include the fix. I also added a gcoap unit test to verify.
This PR uses the nanocoap from my fork, and I hope/expect @kaspar030 will accept the fix into his repository. Until that happens, RIOT can use the commits from the kb2ma nanocoap (sock) repository.