Skip to content

Refactor pyLDAPI.Renderer.render() #9

Description

@edmondchuc

"I will be looking into refactoring parts of the pyLDAPI – more specifically the current requirement of using pyldapi.Renderer._render_alternates_view() for custom Renderer classes. If it’s required to be called manually, it should ideally drop the prefix underscore. Otherwise see if it’s possible to refactor it to the behaviour of the RegisterRenderer class where it’s handled automatically by the tool. "

Here is a live example of a possible solution where the end result will allow the business code to just call SomeClassRenderer.render(): https://repl.it/@edmondchuc/pyLDAPI-Renderer-class-refactor-example

This will keep it in line with the usage of the pyldapi.RegisterRenderer.render().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions