feat: add covering quiver support - #51
Open
pbelmans wants to merge 5 commits into
Open
Conversation
Adapted from QuiverGKM.jl by @dh604, with permission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implementation is adapted from QuiverGKM.jl by @dh604, with permission. GKM predicates and moment-graph construction remain in the GKM-specific package and are intentionally outside this PR.
CoveringDimVectorstill uses mutable vector coordinates for compatibility. The documentation warns against mutating dictionary keys; replacing them with an immutable coordinate type is best handled as a separate API change.Tests
Pkg.test()(run by the pre-push hook)