Skip to content

refactor: share Oscar-independent VGIT predicates - #49

Open
pbelmans wants to merge 2 commits into
bocklandtfrom
vgit-core
Open

refactor: share Oscar-independent VGIT predicates#49
pbelmans wants to merge 2 commits into
bocklandtfrom
vgit-core

Conversation

@pbelmans

Copy link
Copy Markdown
Member

Summary

  • centralize the cached equations and inequalities defining semistable cones and VGIT walls in core QuiverTools
  • provide exact Oscar-independent membership, chamber, and chamber-closure predicates
  • move git_equivalent out of the Oscar extension
  • make Oscar’s sst and cone construction consume the shared data
  • test the core predicates before Oscar is loaded and compare them against Oscar polyhedra afterward

This PR is stacked on #33. The nullcone and wall-projection PR #48 will be rebased onto it.

Tests

  • Pkg.test()
  • 138 focused core/Oscar equivalence checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant