fix(test): restore ProverPipeline loopback fields in test initializers - #613
Merged
CassOnMars merged 1 commit intoAug 18, 2026
Conversation
932045a ("resolve build errors, unified tree model, fix sync") removed local_message_collector: None, current_frame: None, from all three test-side `ProverPipeline` initializers while leaving both fields declared on the struct at crates/quil-engine/src/prover_pipeline.rs:83,87. The `quil-engine` test targets therefore fail to compile: error[E0063]: missing fields `current_frame` and `local_message_collector` in initializer of `ProverPipeline` crates/quil-engine/tests/common/mod.rs:1283 crates/quil-engine/tests/common/mod.rs:1379 crates/quil-engine/tests/e2e_consensus.rs:918 error: could not compile `quil-engine` (test "e2e_epoch_confirm") error: could not compile `quil-engine` (test "e2e_consensus") `cargo check --workspace` does not build test targets, so the `build` job stays green and only `test (cargo nextest)` fails — which is why the branch itself shows no failure (CI runs on PRs only) and every PR targeting v2.1.0.25 goes red at the test step. `None` is the value both fields' own doc comments prescribe for tests ("`None` disables loopback (tests)"), so this restores the prior behaviour exactly and changes no test semantics.
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
932045a3removedlocal_message_collector: Noneandcurrent_frame: Nonefrom all three test-sideProverPipelineinitializers, but both fields are still declared on the struct (crates/quil-engine/src/prover_pipeline.rs:83,87).quil-engine's test targets therefore do not compile:Noneis what both fields' own doc comments prescribe for tests, so this restores prior behaviour exactly — 6 lines, no semantic change.cargo check --workspacedoes not build test targets, sobuildstays green and onlytest (cargo nextest)is affected — on every PR targetingv2.1.0.25.