Replace Wallet features section with quantum secure encrypted money s… - #47
Conversation
…ection Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT 5.6 Sol
Verdict: REQUEST_CHANGES
Blocking finding:
website/src/i18n/en-US.json:440— The new copy says that balances and transfers are encrypted rather than broadcast and that holdings and counterparties remain private. That is broader than the protocol described by this repository's current whitepaper: transparent-address balances and transfers are visible on-chain (website/src/contents/whitepapers/en-US/v0.4.0.mdx:263); wormhole deposit addresses also retain a visible balance; and encrypted exits expose amounts and exit addresses, with privacy explicitly described as probabilistic (:275-277). As written, the wallet page promises privacy the protocol does not provide, and the same promise is propagated to all localized copies. Please distinguish the transparent and encrypted transaction modes, accurately state what encrypted transfers conceal and what remains public, and then synchronize the corrected wording across the nine locales.
Validation:
git diff --check: passed.- All nine changed locale JSON files parse, have complete
wallet.moneykey parity, and generated wallet pages contain the localized content. PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfile: passed.npx --yes bun run build: passed (1,444 pages, including every localized wallet route). The build's missing-translation and compression warnings are in unchanged paths.- Focused Prettier check passed for the changed Astro files and eight locale files;
zh-CN.jsonreports only pre-existing formatting outside this diff.check:seo-metareports only unchangedlaunch.metaentries.
The component replacement, asset references, locale wiring, and responsive structure otherwise look sound, but the public-facing privacy claim needs correction before merge.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Fixed in db3c393. The block now distinguishes transparent and |
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT 5.6 Sol
Verdict: REQUEST_CHANGES — the corrected encrypted-mode copy is now accurate, but the same overbroad privacy claim remains in the Chinese page metadata.
Blocking finding:
website/src/i18n/zh-CN.json:416— The new Chinese meta description still says余额与转账全程加密("balances and transfers are encrypted throughout"). This ships in the page description plus Open Graph and Twitter metadata, contradicts the corrected body at line 440, and is broader than the whitepaper: transparent and wormhole-address balances are visible, encrypted transfers leave amounts visible, and only break the sender-receiver link (website/src/contents/whitepapers/en-US/v0.4.0.mdx:263,275-277). Please remove or replace this extra clause so the Chinese metadata matches the English copy and the protocol.
Validation:
- Reviewed exact base
9f71318783b1cfe9c2a6fe6592ed24afbe1bac60through headdb3c39361bccbae3f7c0d7d55a063c294a7abfc7, including the full diff and follow-up commit. git diff --check: passed; removed section/assets have no stale source references.- All nine changed locale JSON files parse and have matching
wallet.moneykey sets. PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfile: passed.npx --yes bun run build: passed (1,444 pages, including all localized wallet routes).- Focused Prettier check passed for the changed Astro files and eight locale files;
zh-CN.jsonreports only pre-existing formatting at lines 649+ outside this diff.check:seo-metareports only unchangedlaunch.metaentries.
The follow-up correctly fixes all nine wallet.money.blocks.encrypted.body strings, and the component replacement, locale wiring, asset usage, and responsive structure otherwise look sound.
Copy is drafted and needs Jangle's review. The "Encrypted"
block is the one to read closely: it makes a privacy claim
that no longer has a supporting card behind it.