Update ticker and mainnet date - #42
Conversation
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT Sol
Verdict: REQUEST_CHANGES
Two blocking user-facing correctness issues remain:
-
[P2] Update both copies of the mainnet ticker —
website/src/scripts/home/glitch.ts:4buildTicker()renders two copies of every ticker item, but only the first mainnet copy receivesid="ticker-mainnet". This function therefore changes only that first copy. The second copy is still initialized fromhome.hero_banner.ticker.mainnet, which remainsMAINNET: ??(or its localized equivalent) in all nine locale files. As the ticker scrolls, visitors will seeMAINNET: 9/9/26alternate with an unknown date. Please make the scheduled date the shared source value and/or update every rendered mainnet item so both copies agree. -
[P2] Keep the changed Chinese description within the repository's SEO limit —
website/src/contents/blogs/zh-CN/weekly-update-01-21-2026.md:3This description is now 69 code points, below the 70-character CJK minimum enforced by
scripts/check-seo-meta.mjs; the base version was exactly 70. Consequently,npm run check:seo-metareports this changed file as a new failure. Please add accurate wording so the description remains within the enforced range.
Validation on exact head e73898615e2e24b2b8481c8b0df36851f39dc7a0:
git diff --checkpassed.- Production
astro buildpassed (using a temporary npm compatibility install because Bun is unavailable locally). - All 9 locale JSON files parse and have identical 626-key leaf sets; no standalone
QUANreferences remain underwebsite/src. npm run check:seo-metafailed with the new 69-character description above plus 17 baseline launch-metadata issues.npm run format:checkremains red on 16 baseline-formatted files; the changedzh-CN.jsonformatter delta is identical on the base revision.- GitHub reports no CI checks for this head.
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT Sol
Verdict: APPROVE
The two previously reported blockers are resolved at exact head afff9b4640ee4690c1dd0fd08cfe8eb9ea81963d: both ticker copies now read the shared localized 9/9/26 value, and the Chinese weekly-update description is back within the configured CJK metadata range. I found no blocking correctness, security, or compatibility issues.
Validation:
git diff --check ffd9606933f7914ade55996c16a501c94d2564ca...afff9b4640ee4690c1dd0fd08cfe8eb9ea81963dpassed.npx --yes bun@latest testpassed: 4 tests, 0 failures, including the new nine-locale mainnet-date test.SITE_BASE_URL=http://localhost:3000 npm run buildreached Astro's successful static-build and sitemap output. The command retained an open handle after completion and was stopped.- All nine locale JSON files parse with identical scalar-key sets; every mainnet ticker value contains
9/9/26; no standaloneQUANremains underwebsite/srcor in the generated HTML. npx --yes bun@latest run check:seo-metastill reports the same 17 launch-metadata issues as the base revision; the prior PR-introduced Chinese description failure is gone.npx --yes bun@latest run format:checkremains red with 16 files on both base and head. The head replaces the base's Japanese blog warning with a line-wrap warning in the new test; this is non-behavioral but can be cleaned up with the repository formatter.- GitHub reports no CI checks for this head.
Summary