ci: pin the stable rust toolchain - #91
Merged
Merged
Conversation
CI resolved the floating stable channel, so Rust 1.98 shipped the chunks_exact_to_as_chunks clippy lint and failed checks that passed on an older local stable. Pin the exact version, matching how chain pins its toolchains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-toolchainpinnedchannel = "stable", so CI floated to whatever stable was current. Stable 1.98.0 (2026-08-18) added thechunks_exact_to_as_chunksclippy lint, and CI setsRUSTFLAGS: -D warnings, socrates/pow-core/src/lib.rs:15and:19became hard errors.mainhas been red since then — the 🤖 Analysis (Clippy & Doc) job failed on the merges of #88 and #87, and on every PR opened since, including the automated release PR #89. Nothing in the source changed; only the compiler under it did.Pin the exact version, the same way
chainpinsrust-toolchainto1.93.0(and itsrustfmt-toolchainto a dated nightly). This also puts both repos on one Rust version.Verified locally on 1.93.0 via the
rust-toolchaindirectory override, withRUSTFLAGS=-D warnings:cargo fmt --all -- --check— cleancargo clippy --locked --workspace --all-features— cleancargo doc --locked --workspace --no-deps --all-features— cleancargo check --locked --workspace --all-targets— cleanNo source changes, so once this lands, re-running CI on #89 should go green.