fix: search query - #44
Merged
Merged
Conversation
n13
approved these changes
Aug 13, 2026
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT Sol
APPROVE — no blocking findings.
The shared graphqlVariablesForShape helper is used by both the imperative fetch path and the Apollo hook path, and it now makes each payload match the selected operation: hex/text send keyword and limit, while numeric also sends keyword_number. This removes the unexpected variable without changing query selection or response normalization.
Validation:
npx --yes bun run build— passed (Vite production build and TypeScript).- Direct mocked requests for hex, numeric, and text searches, with GraphQL AST assertions that sent and declared variables match — passed.
prettier --check src/api/search.tsxandgit diff --check— passed.- GitHub
Build and Testcheck — passed. npx --yes bun run test -- --runInBand— no tests ran because the existing Jest configuration does not transform the repository's TypeScript/ESM setup; this is outside the diff.
No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correctly build search query variable