Skip to content

fix: search query - #44

Merged
dewabisma merged 1 commit into
mainfrom
beast/fix-search
Aug 13, 2026
Merged

fix: search query#44
dewabisma merged 1 commit into
mainfrom
beast/fix-search

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

Summary

Correctly build search query variable

@dewabisma
dewabisma requested a review from n13 August 13, 2026 05:19

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT Sol

APPROVE — no blocking findings.

The shared graphqlVariablesForShape helper is used by both the imperative fetch path and the Apollo hook path, and it now makes each payload match the selected operation: hex/text send keyword and limit, while numeric also sends keyword_number. This removes the unexpected variable without changing query selection or response normalization.

Validation:

  • npx --yes bun run build — passed (Vite production build and TypeScript).
  • Direct mocked requests for hex, numeric, and text searches, with GraphQL AST assertions that sent and declared variables match — passed.
  • prettier --check src/api/search.tsx and git diff --check — passed.
  • GitHub Build and Test check — passed.
  • npx --yes bun run test -- --runInBand — no tests ran because the existing Jest configuration does not transform the repository's TypeScript/ESM setup; this is outside the diff.

No blocking findings.

@dewabisma
dewabisma merged commit c66e017 into main Aug 13, 2026
1 check passed
@dewabisma
dewabisma deleted the beast/fix-search branch August 13, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants