chore: upgrade action-translation to v0.16.1#132
Merged
Conversation
Both workflows move from v0.15.0. v0.16.1 fixes, relevant to review and rebase mode here: - review mode: CRLF in the PR body no longer breaks source-PR parsing - review mode: paginate listFiles / listComments — PRs over 30 files were reviewed only in part, and past 30 comments the existing review comment was missed, so duplicates accumulated - rebase mode: paginate pulls.list — sibling PRs beyond 100 were skipped - both: a truncated model response now fails loudly instead of being used See QuantEcon/action-translation#83 and the v0.16.1 release notes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for majestic-griffin-10b166 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the QuantEcon/action-translation GitHub Action used by the translation review and rebase workflows from v0.15.0 to v0.16.1, aligning this repo’s automation with upstream fixes (notably pagination, CRLF handling, and truncation detection) described in the PR metadata.
Changes:
- Bump
review-translations.ymltoQuantEcon/action-translation@v0.16.1. - Bump
rebase-translations.ymltoQuantEcon/action-translation@v0.16.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/review-translations.yml | Updates the translation review workflow to use action-translation v0.16.1. |
| .github/workflows/rebase-translations.yml | Updates the translation rebase workflow to use action-translation v0.16.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fetch-depth: 2 | ||
|
|
||
| - uses: QuantEcon/action-translation@v0.15.0 | ||
| - uses: QuantEcon/action-translation@v0.16.1 |
| steps: | ||
| - name: Rebase open translation PRs | ||
| uses: QuantEcon/action-translation@v0.15.0 | ||
| uses: QuantEcon/action-translation@v0.16.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
review-translations.ymlandrebase-translations.ymlonto v0.16.1 (both were v0.15.0).What v0.16.1 fixes for these two modes
\n— so review mode broke permanently on any PR whose body had been edited.listFileswas unpaginated (a PR touching >30 files was only partly reviewed);listCommentswas too, so past 30 comments the existing review comment wasn't found and duplicates accumulated.pulls.listwas capped at 100, so sibling PRs beyond that were never rebased.max_tokenswas used as if complete; it now fails loudly.Validated before the bump: the 26-scenario e2e harness ran v0.16.1 against
test-translation-sync.fa— 26/26 correct translation PRs, covering the RTL path specifically.Note the companion PR in the source repo (QuantEcon/lecture-python-programming#575) moves this language's sync workflow to v0.16.1, which is also the Sonnet 4.6 → Sonnet 5 default-model change. This PR only affects review and rebase, which run here.
Detail: QuantEcon/action-translation#83 · v0.16.1 release notes
🤖 Generated with Claude Code