Skip to content

Fix explicit HTTPS port handling for reverse proxies #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlackRockCity wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix explicit HTTPS port handling for reverse proxies #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions mitm_redirect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,17 @@ def _rewrite_value(text: str) -> str:
args.local_api,
fallback_port=DEFAULT_LOCAL_API_PORT,
)
local_api = _format_authority(local_api_host, local_api_port, default_port=443)
# Preserve an explicit API port in the value passed to the mitmproxy addon.
# This prevents an explicitly supplied :443 from being lost and later
# falling back to DEFAULT_LOCAL_API_PORT (555) inside the addon.
local_api = _format_authority(local_api_host, local_api_port)

# For direct HTTPS requests made by this launcher (preflight), normalize
# the standard HTTPS port out of the URL authority. This still connects to
# TCP 443, but avoids sending an explicit Host: hostname:443 header, which
# can trigger HAProxy routing quirks in some configurations.
local_api_http = _format_authority(local_api_host, local_api_port, default_port=443)

local_mqtt_host, local_mqtt_port = _parse_endpoint(
args.local_mqtt or "",
fallback_host=local_api_host,
Expand Down Expand Up @@ -725,11 +735,11 @@ def _rewrite_value(text: str) -> str:

if local_sync_secret:
try:
_preflight_sync_endpoint(local_api, local_sync_secret)
_preflight_sync_endpoint(local_api_http, local_sync_secret)
except SyncEndpointError as exc:
print(f"[SYNC] refusing to start mitmweb: {exc}", file=sys.stderr)
sys.exit(2)
print(f"[SYNC] verified protocol auth sync endpoint via {_sync_callback_url(local_api)}")
print(f"[SYNC] verified protocol auth sync endpoint via {_sync_callback_url(local_api_http)}")
else:
print("[SYNC] protocol auth session sync disabled: no sync secret configured")

Expand Down