Support parsing non-seekable streams - #604
Open
probberechts wants to merge 1 commit into
Open
Conversation
probberechts
force-pushed
the
fix-issue-469
branch
from
August 6, 2026 14:12
56b47b6 to
e851e5f
Compare
Some deserializers (such as Wyscout and SkillCorner) support multiple data formats. The format can either be specified explicitly or detected automatically. Auto-detection reads part of the input to extract version information before parsing the file again from the start. While this works for local files, it fails for non-seekable streams, such as files accessed over S3 or HTTPS. To fix this, this commit makes open_as_file buffer direct file-like objects that are not seekable into a seekable BufferedStream, consistent with adapter-backed input behavior. It also modifies Wyscout and Skillcorner parsers to open the event stream once and pass the opened seekable object down for version identification before finally parsing. Fixes PySport#496
probberechts
force-pushed
the
fix-issue-469
branch
from
August 6, 2026 14:51
e851e5f to
2d85a7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some deserializers (such as Wyscout and SkillCorner) support multiple data formats. The format can either be specified explicitly or detected automatically. Auto-detection reads part of the input to extract version information before parsing the file again from the start. While this works for local files, it fails for non-seekable streams, such as files accessed over S3 or HTTPS.
To fix this, this commit makes
open_as_filebuffer direct file-like objects that are not seekable into a seekableBufferedStream, consistent with adapter-backed input behavior. It also modifies Wyscout and Skillcorner parsers to open the event stream once and pass the opened seekable object down for version identification before finally parsing.Fixes #469