Increase default button timeout to 1000 milliseconds#720
Open
albertvaka wants to merge 1 commit into
Open
Conversation
Many interfaces make use of long-press of buttons to open context menus. Auto-releasing buttons after just 500 ms is too short for most applications to detect this as a long-press.
Contributor
|
The CEC specification defines press and hold repeat times of 200ms to 500ms, with a recommended value of 450ms, and this is one of the instances where the spec says |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many interfaces make use of long-press of buttons, for example to open context menus.
Auto-releasing buttons after just 500 ms is too short for most applications to detect this as a long-press.
This change makes the default auto-release timeout long enough to not interfere with UIs that need long-press.
I am aware that this default has been like that for a long time, but I still think it is not a good default and, given we are going to release a new major version, it's a good opportunity to change it.