Skip to content

Dummy PR to review approver acces - #551

Open
pm-nitin-shirsat wants to merge 28 commits into
nightlyfrom
gpp_pg_bo_l1_changes
Open

Dummy PR to review approver acces#551
pm-nitin-shirsat wants to merge 28 commits into
nightlyfrom
gpp_pg_bo_l1_changes

Conversation

@pm-nitin-shirsat

Copy link
Copy Markdown

No description provided.

pm-nitin-shirsat and others added 28 commits April 4, 2023 11:37
Sync gpp branch with nightly
Merginbg GPP chnages tp pg_bo_l1 changes for QA regression
Comment thread src_new/common.config.js
prebidConfig["consentManagement"][key] = {
cmpApi: cmpApi,
timeout: timeout
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
};
};

Comment thread src_new/common.config.js

exports.setConsentConfig = function (prebidConfig, key, cmpApi, timeout) {
prebidConfig = prebidConfig || {};
if (!prebidConfig["consentManagement"]) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
if (!prebidConfig["consentManagement"]) {
if (!prebidConfig["consentManagement"]) {

Comment thread src_new/common.config.js
prebidConfig = prebidConfig || {};
if (!prebidConfig["consentManagement"]) {
prebidConfig["consentManagement"] = {};
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
}
}

Comment thread src_new/common.config.js
prebidConfig["consentManagement"] = {};
}
prebidConfig["consentManagement"][key] = {
cmpApi: cmpApi,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change
cmpApi: cmpApi,
cmpApi: cmpApi,

Comment thread src_new/common.config.js
if (!prebidConfig["consentManagement"]) {
prebidConfig["consentManagement"] = {};
}
prebidConfig["consentManagement"][key] = {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
prebidConfig["consentManagement"][key] = {
prebidConfig["consentManagement"][key] = {

Comment thread src_new/common.config.js
};

exports.setConsentConfig = function (prebidConfig, key, cmpApi, timeout) {
prebidConfig = prebidConfig || {};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
prebidConfig = prebidConfig || {};
prebidConfig = prebidConfig || {};

Comment thread src_new/common.config.js
cmpApi: cmpApi,
timeout: timeout
};
return prebidConfig;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change
return prebidConfig;
return prebidConfig;

Comment thread src_new/common.config.js
exports.setConsentConfig = function (prebidConfig, key, cmpApi, timeout) {
prebidConfig = prebidConfig || {};
if (!prebidConfig["consentManagement"]) {
prebidConfig["consentManagement"] = {};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change
prebidConfig["consentManagement"] = {};
prebidConfig["consentManagement"] = {};

Comment thread src_new/common.config.js
}
prebidConfig["consentManagement"][key] = {
cmpApi: cmpApi,
timeout: timeout

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change
timeout: timeout
timeout: timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants