Skip to content

Geo detection changes IDNT-589 - #454

Closed
pm-priyanka-deshmane wants to merge 41 commits into
nightly_30Mayfrom
GeoDetection
Closed

Geo detection changes IDNT-589#454
pm-priyanka-deshmane wants to merge 41 commits into
nightly_30Mayfrom
GeoDetection

Conversation

@pm-priyanka-deshmane

Copy link
Copy Markdown
Collaborator

No description provided.

pm-nitin-shirsat and others added 30 commits January 25, 2023 15:38
Sync gpp branch with nightly
* IDNT- Deep merge function introduced to solve ids override issues

* IDNT- Deep merge function introduced to solve ids override issues in utils.js

* Override ids code fixes

* IDNT-588: Code analysis review comments resolved
// tdod: we can still reduce the build size for idhub by,
// - create a separate constants.js with limited required functions

var OW_CONFIG = require("../config.js");

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-manasi-moghe Confirm this change.

@pm-priyanka-deshmane

Copy link
Copy Markdown
Collaborator Author

Raised a newer PR against nightly
#462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants