fix(sdk): return transactionHash from cancelOrder method - #1983
Closed
Lesnak1 wants to merge 1 commit into
Closed
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Lesnak1
force-pushed
the
fix/issue-1981-cancelorder-return-transaction-hash
branch
from
August 10, 2026 16:58
ef2dadd to
49c1f75
Compare
Collaborator
|
Thanks @Lesnak1, appreciate you taking this on. It duplicates #1982, which landed the same fix for #1981 a couple of weeks earlier, so we've carried that one into our internal source repo with credit to its author. The fix will go out in the next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1981.
Ensures the singular
cancelOrdermethod returns thetransactionHashstring, aligning its return interface behavior withcancelOrders.Rationale
Allows developers to receive and track the transaction hash immediately after initiating single order cancellations.
Verification
npm run build(tsc) without errors.npm test): 791/791 tests passed cleanly.