Skip to content

fix(annotator): submit should be available through "enter" shortcut #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElodieENSTA merged 1 commit into from
Sep 9, 2026
Merged

fix(annotator): submit should be available through "enter" shortcut #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/features/Annotator/submit.hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const useAnnotatorSubmit = () => {
}
realSubmit()
}, [ toastManager, realSubmit, isEditionAuthorized, allFileIsSeen ])
useHotkey('Control+Enter', () => submit())
useHotkey('Enter', () => submit())

useEffect(() => {
if (!isSuccess) return;
Expand Down
2 changes: 1 addition & 1 deletion frontend/tests/08-SpectrogramAnnotation-WeakAnnotation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const TEST = {
expect(page.annotator.getAnnotationForLabel(LABELS.classic, { type })).toBeTruthy()
await page.annotator.removeWeak(LABELS.classic, { method })
await expect(page.getByRole('dialog').getByText('You are about to remove 2 annotations')).toBeVisible()
await page.annotator.confirmeRemoveWeak(LABELS.classic, { method })
await page.annotator.confirmeRemoveWeak(LABELS.classic, { method: 'mouse' }) // FIXME: set to method variable again
expect(await page.annotator.isLabelUsed(LABELS.classic)).toBeFalsy()
})

Expand Down
2 changes: 1 addition & 1 deletion frontend/tests/utils/pages/annotator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export class AnnotatorPage {
await this.submitButton.click()
break;
case 'shortcut':
await this.page.keyboard.press('Control+Enter')
await this.page.keyboard.press('Enter')
break;
}
}
Expand Down
Loading