fix pipe mapper message for diameter - #362
Merged
MichielTukker merged 5 commits intoAug 23, 2026
Merged
Conversation
samvanderzwan
previously requested changes
Jul 16, 2026
MichielTukker
self-requested a review
August 21, 2026 07:05
MichielTukker
approved these changes
Aug 23, 2026
MichielTukker
dismissed
samvanderzwan’s stale review
August 23, 2026 14:28
Requested changes have been implemented
MichielTukker
deleted the
361-fix-message-raised-for-missing-pipe-diameter-eventhough-its-available
branch
August 23, 2026 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small fix for the messages shown in the terminal for the diameter. Currently messages shows value None is used if default value is used as diameter. Also, because the message is raised by get_property method, it doesnt indicate correctly if its the inner diameter or diameter which is missing.