Conversation
cwang39403
reviewed
Aug 10, 2026
cwang39403
approved these changes
Aug 25, 2026
cwang39403
left a comment
cwang39403
left a comment
Contributor
There was a problem hiding this comment.
Can be closed after the comments are resolved.
| "DB_PASSWORD": "pass", | ||
| "PREFECT_API_AUTH_STRING": "token", | ||
| "PREFECT_API_URL_FOR_WORKER": "http://prefect:4200/api", | ||
| "MINIO_HOST": "minio:9000", |
| # Capture and forward solver output only during orchestrated Prefect flow runs. | ||
| capture_session = StdCaptureToLogSession() if in_prefect_flow_context() else nullcontext() | ||
| with capture_session: | ||
| minio_host = os.environ.get("MINIO_HOST") |
Contributor
There was a problem hiding this comment.
Inconsistent way of getting env variables, some are fetched this way and some via EnvSettings. Minor and fine to keep it like this though.
| esdl_output_profiles_type_str = os.environ.get("ESDL_OUTPUT_PROFILES_TYPE", "POSTGRESQL").upper() | ||
| esdl_output_profiles_type = ( | ||
| None | ||
| if esdl_output_profiles_type_str == "NO_DB_WRITE_FOR_TEST" |
Contributor
There was a problem hiding this comment.
This is probably not required? as esdl_output_profiles_type will be None if esdl_output_profiles_type_str = "NO_DB_WRITE_FOR_TEST" and the condition below (107) is preventing esdl_output_profiles_type to be set as POSTGRESQL.
Maybe nice to log a message, e.g., logging.info("ESDL_OUTPUT_PROFILES_TYPE set to NO_DB_WRITE_FOR_TEST, skipping DB write.") when this condition meet? esdl_output_profiles_type_str == "NO_DB_WRITE_FOR_TEST"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.