Conversation
cwang39403
approved these changes
Aug 7, 2026
cwang39403
left a comment
cwang39403
left a comment
Contributor
There was a problem hiding this comment.
Looking good. Glad to see pyesdl and omotes-sdk-protocol are removed from dependency.
Added some minor comments.
cwang39403
approved these changes
Aug 25, 2026
| artifacts_by_key: dict[str, dict[str, Any]] = {} | ||
| for artifact in artifacts: | ||
| artifact_key = artifact.key or str(artifact.id) | ||
| artifact_data = await _resolve_artifact_data( |
Contributor
There was a problem hiding this comment.
Optional: minio_result_storage is built on every iteration inside _resolve_artifact_data(), and then parsing the path to read object. Probably more efficient if the storage block is built once outside the loop and passed as something like minio_block: RemoteFileSystem into _resolve_artifact_fata()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.