Skip to content

FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devmiguelangel wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission #9007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3fcfe
feat: refactor process manager check and enhance view policy
devmiguelangel Aug 24, 2026
8ab16f3
test: add tests for process manager request visibility and permissions
devmiguelangel Aug 24, 2026
bc5249b
test: enhance process manager permissions and request visibility tests
devmiguelangel Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ProcessMaker/Http/Controllers/RequestController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
$addons = $this->getPluginAddons('edit', compact(['request']));
$dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

$isProcessManager = $request->process?->manager_id === Auth::user()->id;
$isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

$eligibleRollbackTask = null;
$errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down
4 changes: 4 additions & 0 deletions ProcessMaker/Policies/ProcessRequestPolicy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ public function before(User $user)
*/
public function view(User $user, ProcessRequest $processRequest)
{
if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
return true;
}

// Policy defined in ForUserScope
return ProcessRequest::forUser($user)
->where('process_requests.id', $processRequest->id)
Expand Down
200 changes: 200 additions & 0 deletions tests/Feature/Api/ProcessRequestPolicyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand Down Expand Up @@ -72,4 +73,203 @@ public function testUserHasPermission()
$response = $this->apiCall('GET', $route);
$response->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
{
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
'manager_id' => [$firstManager->id, $this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
ProcessRequestToken::factory()->create([
'element_id' => 'node_18',
'element_type' => 'end_event',
'process_id' => $process->id,
'process_request_id' => $request->id,
'status' => 'CLOSED',
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
->assertJsonPath('data.endEventDestination.value', null);
}

public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
{
$managedProcess = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$unmanagedRequest = ProcessRequest::factory()->create();

$this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

$this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
->assertStatus(403);

$this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
->assertStatus(403);
}

public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$process->manager_id = [];
$process->save();

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(403);
}

public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('PUT', route('api.requests.update', [$request]), [
'name' => 'Unauthorized update',
])->assertStatus(403);

$this->apiCall('DELETE', route('api.requests.destroy', [$request]))
->assertStatus(403);
}

public function testManagedRequestIsNotAddedToRequestListing()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$this->apiCall('GET', route('api.requests.index'))
->assertStatus(200)
->assertJsonMissing(['id' => $request->id]);
}

public function testScalarProcessManagerValueIsNormalizedForAuthorization()
{
$process = Process::factory()->create([
'manager_id' => $this->user->id,
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->assertSame([$this->user->id], $process->fresh()->manager_id);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}

public function testProcessManagerReassignmentUpdatesRequestAccess()
{
$newManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$process->manager_id = [$newManager->id];
$process->save();

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(403);

$this->user = $newManager;

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestsInEveryStatus()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);

foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => $status,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}
}

public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data', null);
}

public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
{
$bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
$bpmn = str_replace(
'{"type":"summaryScreen","value":null}',
'{"type":"externalURL","value":"https://example.com/summary"}',
$bpmn,
);
$process = Process::factory()->create([
'bpmn' => $bpmn,
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
ProcessRequestToken::factory()->create([
'element_id' => 'node_18',
'element_type' => 'end_event',
'process_id' => $process->id,
'process_request_id' => $request->id,
'status' => 'CLOSED',
]);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data.endEventDestination.type', 'externalURL')
->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
}
}
25 changes: 25 additions & 0 deletions tests/Feature/CasesControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
$response->assertStatus(403);
}

public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
{
$processManager = User::factory()->create();
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$firstManager->id, $processManager->id],
]);
$request = ProcessRequest::factory()->create([
'parent_request_id' => null,
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
$route = route('cases.show', ['case_number' => $request->case_number]);

$response = $this->actingAs($processManager)->get($route);

$response->assertStatus(200);
$response->assertViewIs('cases.edit');
$response->assertViewHas('isProcessManager', true);

$this->actingAs(User::factory()->create())
->get($route)
->assertStatus(403);
}

public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
{
Permission::firstOrCreate(
Expand Down
50 changes: 50 additions & 0 deletions tests/Feature/RequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand Down Expand Up @@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
$response->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestSummary()
{
$this->user = User::factory()->create();
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$firstManager->id, $this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);

$response = $this->webCall('GET', route('requests.show', [$request]));

$response->assertStatus(200);
$response->assertViewIs('requests.show');
$response->assertViewHas('isProcessManager', true);
}

public function testProcessManagerCannotViewUnmanagedRequestSummary()
{
$this->user = User::factory()->create();
Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$unmanagedRequest = ProcessRequest::factory()->create();

$this->webCall('GET', route('requests.show', [$unmanagedRequest]))
->assertStatus(403);
}

public function testProcessManagerCannotViewAllRequestsWithoutPermission()
{
Permission::firstOrCreate(
['name' => 'view-all_requests'],
['title' => 'View All Requests'],
);
Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

$this->user = User::factory()->create();
Process::factory()->create([
'manager_id' => [$this->user->id],
]);

$this->webCall('GET', route('requests_by_type', ['type' => 'all']))
->assertStatus(403);
}

public function testShowRouteWithAdministrator()
{
$this->user = User::factory()->create([
Expand Down
Loading