Skip to content

FOUR-32723: Unify Smart Extract error presentation - #8994

Open
eiresendez wants to merge 3 commits into
developfrom
task/FOUR-32723
Open

FOUR-32723: Unify Smart Extract error presentation#8994
eiresendez wants to merge 3 commits into
developfrom
task/FOUR-32723

Conversation

@eiresendez

@eiresendez eiresendez commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Smart Extract returns an actionable conversion error for unsupported GIF files. The Script Microservice already displayed a concise message, but the custom Docker executor persisted the fatal-error wrapper and full executor and ProcessMaker stacks in case errors.

Solution

  • Keep structured Smart Extract model details as the actionable error source.
  • For package-smart-extract/document-send only, omit raw output from the early Docker binding log and record the complete diagnostic later after redacting credentials.
  • Pass a concise ScriptException to retries, notifications, and request errors.
  • Redact complete Authorization values, including Basic and Token schemes, and preserve Bearer and JWT redaction.
  • Truncate messages safely without breaking UTF-8.
  • Preserve missing service task implementation errors and keep every other custom executor unchanged.

How to Test

  • Core: 18 tests, 38 assertions.
  • Package Smart Extract: 3 tests, 12 assertions.
  • Custom Docker executor: local case 12 displays only the actionable GIF conversion message and no stack trace.
  • Script Microservice: local case 20 keeps the same concise presentation.
  • Smart Extract raw output is omitted from the early binding log; the later technical diagnostic remains available with credentials redacted.
  • A missing service task implementation remains Service task implementation not defined instead of causing a TypeError.

Related Tickets & Packages

ci:deploy
ci:package-smart-extract:task/FOUR-32723

@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-5b410e2a9e.engk8s.processmaker.net

@eiresendez eiresendez changed the title FOUR-32723: Surface Script Microservice error details FOUR-32723: Unify Smart Extract error presentation Aug 18, 2026
@processmaker-sonarqube

Copy link
Copy Markdown

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-5b410e2a9e.engk8s.processmaker.net

@eiresendez
eiresendez requested a review from mcraeteisha August 18, 2026 16:58
@eiresendez eiresendez self-assigned this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants