Skip to content

Fix duplicate script modal validation error persisting after close - #8878

Merged
nolanpro merged 1 commit into
developfrom
observation/FOUR-30054
Aug 21, 2026
Merged

Fix duplicate script modal validation error persisting after close#8878
nolanpro merged 1 commit into
developfrom
observation/FOUR-30054

Conversation

@sanjacornelius

@sanjacornelius sanjacornelius commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

This PR fixes an issue in the Copy Script modal where the "name already exists" validation error would remain visible after closing and reopening the modal.

The error state was not being cleared when the modal was reopened, causing old validation messages to persist even before attempting another duplicate action.

Solution

  • Added this.errors = {} to showModal() to reset the modal state before displaying it.

How to Test

Follow the testing steps provided in the ticket.

Related Tickets & Packages

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Clear any existing validation/errors when opening the duplicate script modal by setting `this.errors = {}` in showModal(). This prevents stale error state from persisting when the modal is reopened.
@processmaker-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Kookster310

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://ci-fb5d822a20.engk8s.processmaker.net

@nolanpro
nolanpro merged commit f28ff4e into develop Aug 21, 2026
10 of 15 checks passed
@nolanpro
nolanpro deleted the observation/FOUR-30054 branch August 21, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants