PENTRC: document atol_x/rtol_x controls and fix precision suffix (cleanup for #280) - #290
Merged
Merged
Conversation
…ffix Follow-up cleanup for the nested-quadrature tolerance split: adds the new atol_x/rtol_x energy-integration controls to the master input template, corrects the atol_xlmda/rtol_xlmda comments in all templates (pitch-only now, with energy tolerances derived unless overridden), and gives the nested_tolerance_margin parameter its _r8 suffix per code conventions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rewp8poxoQyorK48SwxEUv
logan-nc
force-pushed
the
pentrc_tolerance_docs_cleanup
branch
from
August 4, 2026 20:19
dede10a to
a4b097e
Compare
logan-nc
marked this pull request as ready for review
August 4, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-blocking cleanup items from the #280 review, as a follow-up so #280 could merge as-authored:
atol_x/rtol_xenergy-integration controls toinput/pentrc.inwith comments explaining the derive-from-pitch default (1e-2margin).atol_xlmda/rtol_xlmdacomments in the master template and all 14 example decks: they are pitch-only tolerances now, with the energy tolerances derived unless overridden (PENTRC: fix OpenMP data race on the energy contour flag (and a nested-quadrature tolerance defect) #280 made the old "energy and pitch" wording untrue).nested_tolerance_margin = 1e-2→1e-2_r8per the project's precision conventions.No behavior change: the
_r8suffix shifts the margin only at the single-vs-double literal conversion level (~5e-10 relative), and the template edits are comments plus explicit defaults.Draft until #280 (and #281) merge — this branch is based on #280's head so the diff currently includes its commits; it collapses to the 16-file cleanup once #280 lands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rewp8poxoQyorK48SwxEUv