Refactor usage constants into factory functions - #1137
Open
Pratham-ds wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor usage and model constants into factory functions in
AgentEMPTY_USAGEandDEFAULT_MODELconstants withcreateEmptyUsage()andcreateDefaultModel()factory functions so each caller gets a unique object instance, preventing shared-state mutations.Agent.resetnow throws if called while a run is active; callers must wait for idle before resetting.Agent.finishRunclearsactiveRunbefore resolving the run promise, soisProcessingisfalseduring resolution callbacks.Agent.processEventsiterates over a snapshot of listeners, so subscribe/unsubscribe calls during dispatch take effect only on subsequent events.Agent.isProcessinggetter that returnstruewhen a run is active.resetduring an active run now throws instead of silently clearing state.Macroscope summarized 2850a37.