feat(windows): add installer and runtime support - #1119
Open
j-token wants to merge 4 commits into
Open
Conversation
…otstrap Adds install.ps1, a PowerShell installer that mirrors install.sh: it resolves the release channel, downloads the tarball and SHA256SUMS, verifies the SHA-256 checksum, installs with npm, and can prepare the IPython runtime. The installer body runs inside a script block so `irm ... | iex` does not leak helpers or preferences into the caller's session. Makes the kernel bootstrap work on Windows: uv is installed with the official PowerShell installer and looked up in its Windows install locations, and the managed venv interpreter resolves to Scripts/python.exe. Non-Windows behavior is unchanged. The release workflow now renders and publishes install.ps1 and install-beta.ps1 alongside the shell installers, and check-installer-render.mjs validates both.
bootstrapVenv and ensureKernelPythonUncached built the interpreter path as <venv>/bin/python, which only exists on POSIX. On Windows the interpreter is at <venv>/Scripts/python.exe, so uv pip install --python got a path that does not exist and exited 2, leaving the kernel unusable. The same path feeds kernelReady, so on Windows it was always false: every launch fell through to bootstrapVenv, which runs uv venv --seed and recreates the venv. A manually provisioned venv was therefore discarded on the next run. Add venvPython to pick the layout from process.platform, matching the existing win32 branch in findExecutable, and use it at both sites. Update the two integration tests that hardcoded the POSIX candidate path. Fixes PrimeIntellect-ai#660 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uvthrough the official Windows installer during kernel bootstrapScripts/python.exeon WindowsTests
npm run checkcompleted Biome and TypeScript checks; the existing installer-render PTY harness then exited with an unknown status on Windows, which also reproduces onupstream/maintest/clipboard.test.tspassedNote
Add Windows installer and runtime support for Prime Agent
venvPython()in bootstrap.ts to resolve the correct venv interpreter path (Scripts/python.exeon Windows,bin/pythonelsewhere), fixing kernel bootstrap on Windowsirm ... | iex) with platform-aware binary location discovery inensureUvwindowsHide: trueto allspawn/spawnSync/execSynccalls across the codebase to suppress console windows on Windowsinstall.ps1andinstall-beta.ps1to the release bucket alongside the existing shell installerMacroscope summarized 9f36fad.