feat: About this market modal#623
Merged
greatest0fallt1me merged 1 commit intoJul 25, 2026
Merged
Conversation
Implements accessible 'About this market' educational modal detailing resolution criteria and oracle parameters for the GrantFox FWC26 campaign. ## What Changed - Created new Client Component `AboutMarketModal` detailing the prediction market's question, oracle source, target resolution date, and Yes/No outcome criteria. - Updated `MarketHero` to support rendering this modal trigger in its Actions row. - Updated the market page Server Component to pass the modal into the hero component. - Fixed a compilation error in `components/ui/dialog.tsx` where `useRef` was referenced without prefixing `React.`. - Registered `AboutMarketModal` in the internal accessibility board (`app/a11y-audit/page.tsx`), the documentation board (`docs/a11y-status.md`), and the accessibility manifest (`app/data/a11y-manifest.json`). ## Accessibility - Screen reader announcements: Uses explicit labels (`aria-labelledby`/`aria-describedby`) and comprehensive hidden `sr-only` descriptions for screen readers. - Keyboard trapping and return: Implements `DialogContentWithFocusReturn` to ensure focus is restored to the trigger button when the modal closes. - Color contrast: Meets WCAG 2.1 AA text contrast requirements in both light and dark modes. ## Test Output Added unit and integration test suites: - PASS app/components/__tests__/AboutMarketModal.test.tsx - PASS app/markets/[id]/__tests__/hero.test.tsx - PASS app/__tests__/a11y-manifest.test.js Closes Predictify-org#362
|
@AdEmOnD07 is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@AdEmOnD07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
Contributor
|
LGTM — solid tests too. Merged 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements accessible 'About this market' educational modal detailing resolution criteria and oracle parameters for the GrantFox FWC26 campaign.
What Changed
AboutMarketModaldetailing the prediction market's question, oracle source, target resolution date, and Yes/No outcome criteria.MarketHeroto support rendering this modal trigger in its Actions row.components/ui/dialog.tsxwhereuseRefwas referenced without prefixingReact..AboutMarketModalin the internal accessibility board (app/a11y-audit/page.tsx), the documentation board (docs/a11y-status.md), and the accessibility manifest (app/data/a11y-manifest.json).Accessibility
aria-labelledby/aria-describedby) and comprehensive hiddensr-onlydescriptions for screen readers.DialogContentWithFocusReturnto ensure focus is restored to the trigger button when the modal closes.Test Output
Added unit and integration test suites:
Closes #362
Pull Request
Description
Type of Change
Related Issues
Closes #[issue-number]
Related to #[issue-number]
Changes Made
Files Modified
Key Changes
Testing
Test Coverage
Screenshots/Videos
Minimum screenshots for UI/design PRs
Before
After
Pre-submission Checklist
Code Quality
Functionality
Documentation
Security & Accessibility
Breaking Changes
Breaking Changes:
Migration Steps:
Additional Notes
Dependencies
Performance Impact
Browser/Device Support
Labels
feature- for new featuresbugfix- for bug fixesdocumentation- for documentation changesenhancement- for improvementsbreaking-change- for breaking changesfrontend- for frontend changesbackend- for backend changesui/ux- for design changesReviewers
Note: Please ensure all checkboxes are completed before submitting this PR. This helps maintain code quality and speeds up the review process.