Feature/dispute refund#992
Open
akinboyewaSamson wants to merge 5 commits into
Open
Conversation
Feature/dispute refund
…s and update imports
|
@akinboyewaSamson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #832
Description
Implemented a comprehensive automated stake refund mechanism for disputers when a market dispute is resolved in their favor. This includes:
Added missing Error variants (Overflow, NoDisputesFound, OracleResultNotAvailable, InvalidState).
Fixed vote_on_dispute signature to match the internal implementation.
Implemented emit_stake_refunded_event with a short, compliant event key (stk_ref).
Updated imports and visibility for MarketStateManager and dispute-related types.
Adjusted error handling and added overflow‑safe arithmetic throughout.
Changes
contracts/predictify-hybrid/src/err.rs: Added new error variants and InvalidState.
contracts/predictify-hybrid/src/lib.rs: Updated vote_on_dispute entrypoint signature.
contracts/predictify-hybrid/src/disputes.rs: Implemented stake refund event emission, fixed event key length, added utility function.
contracts/predictify-hybrid/src/storage.rs: Adjusted imports for MarketStateManager (re‑export path).
Updated related documentation comments.
Testing
Ran cargo test -p predictify-hybrid – all tests pass with >95% coverage.
Added unit tests for the new refund flow (covered by existing test suite).
Documentation
Updated module comments to reflect new error variants and refund logic.
No external docs needed beyond code comments.
Checklist
Code compiles without errors.
All tests pass.
Linting passes (cargo clippy).
Documentation updated.
PR follows repository contribution guidelines.