docs: note that PA_ALSA_DYNAMIC defaults to OFF - #1164
Merged
philburk merged 1 commit intoAug 8, 2026
Merged
Conversation
CMakeLists.txt sets PA_ALSA_DYNAMIC to OFF, but the blanket note above the backend options list states everything defaults to ON except the OSS, ASIO, and skeleton backends -- PA_ALSA_DYNAMIC isn't listed among those exceptions, so a reader following the note would expect it to default to ON. Fixes PortAudio#1163
philburk
approved these changes
Aug 7, 2026
philburk
left a comment
philburk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. I can see that it is set to OFF in CMakeLists.txt
option(PA_ALSA_DYNAMIC "Enable dynamically loading libasound with dlopen using PaAlsa_SetLibraryPathName" OFF)
RossBencina
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txtsetsPA_ALSA_DYNAMICtoOFF, but the note above the backend options list states everything defaults toONexcept the OSS, ASIO, and skeleton backends —PA_ALSA_DYNAMICisn't listed among those exceptions, so a reader following the note would expect it to default toON.This adds a footnote (matching the existing style used for the OSS exception) clarifying the actual default, rather than changing the build default itself.
Fixes #1163