Split config/panel.py over multiple files - #454
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config/panel.pyhas become enormous in #386, this PR splits it over several files to hopefully make the review a little easier.Note
Low Risk
Pure file split with no intended behavior change. Residual risk is import-cycle or docstring-link breakage if a name is not re-exported correctly.
Overview
Turns the single ~1500-line
pixelator.pna.config.panelmodule into a package so panel types, loaders, combinations, and diffs live in separate files.Public names (
PNAPanel, typed panels,PNAAntibodyPanelCombination,PNAAntibodyPanelDiff, loaders, and the deprecatedPNAAntibodyPanelalias) are re-exported frompanel/__init__.py, so existingfrom pixelator.pna.config.panel import ...usage should keep working. Sphinx cross-refs in a few docstrings were updated to the new submodule paths.Reviewed by Cursor Bugbot for commit 7f9cd49. Bugbot is set up for automated code reviews on this repo. Configure here.