Fix apply stage on Windows and make dry-run side-effect-free - #93
Open
ArchieChelle wants to merge 1 commit into
Open
Fix apply stage on Windows and make dry-run side-effect-free#93ArchieChelle wants to merge 1 commit into
ArchieChelle wants to merge 1 commit into
Conversation
- Resolve the claude CLI via shutil.which() before spawning it. Windows could not launch the bare "claude" name (it is claude.cmd), failing every apply with WinError 2. - Fix the --url apply selector: "apply_status != 'in_progress'" excluded never-applied jobs because NULL != 'in_progress' is NULL in SQL. Now NULL-safe, matching the queue selector. - Make --dry-run a true preview. A top-priority DRY RUN RULES block stops the agent before any account creation, data entry, upload, or submit; it emits a distinct RESULT:DRY_RUN token, and the launcher records it as neither applied nor failed (previously it created accounts, entered data, and mislabeled the job as "applied"). - Ignore .venv/ in git. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
claudecommand name, which fails on Windows withWinError 2(the actual executable isclaude.cmd). Every apply attempt failed on Windows.--urlselector bug: the apply selector usedapply_status != 'in_progress', which excludes never-applied jobs becauseNULL != 'in_progress'evaluates toNULLin SQL, not true. Jobs that had never been touched were silently skipped.--dry-runwasn't side-effect-free: dry runs could still create accounts, enter data, and upload files, and successful dry runs were mislabeled as "applied" in the database.Fixes
claudeCLI viashutil.which()before spawning, so Windows findsclaude.cmd.apply_statusselector NULL-safe, matching the queue selector's logic.RESULT:DRY_RUNtoken and are recorded as neither applied nor failed..venv/in git.Scope
src/applypilot/apply/launcher.py,src/applypilot/apply/prompt.py,.gitignore.